Skip to content

feat: Multi factor Authentication #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 29 commits into
base: development
Choose a base branch
from
Open

feat: Multi factor Authentication #1273

wants to merge 29 commits into from
+3,362 −74

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 3, 2025 •
edited
Loading

Full flow for MFA.

  • TOTP and SMS enrolment.
  • TOTP and SMS management from signed-in view (SignedInView). Can add and remove factors from this state.
  • TOTP and SMS un-enrolment from signed in state.
  • UI tests for enrolment flow for SMS, does not have TOTP as it's not supported by emulator.
  • UI tests for removing factors from sign-in state.
  • UI tests for SMS resolution (up to the point of signing in as it fails here due to lack of emulator support).

@russellwheatley russellwheatley changed the title feat: MFA enrolment flow feat: Multi factor Authentication Oct 3, 2025
@russellwheatley russellwheatley marked this pull request as ready for review October 3, 2025 14:09
@russellwheatley
feat: MFA enrolment flow
36b1c77
@russellwheatley
fix: make secret internal but not private
5d75816
@russellwheatley
feat: integrate MFA enrolment View
bb34c52
@russellwheatley
ci: update SwiftUI CI workflow
c5aa33a
@russellwheatley
test: unit tests for enrolment
8d9e8bc
@russellwheatley
test: integration test updates
a661857
@russellwheatley
test: fix UI tests
54bb93e
@russellwheatley
test: remove Timer from UI tests
d97238b
@russellwheatley
test: MFA enrolment tests
55f95b8
@russellwheatley
test: bifurcate test setup with content view + test helpers
0307ebd
@russellwheatley
chore: clean up
ba2c62c
@russellwheatley
feat: MFA management and resolution logic
0807e7c
@russellwheatley
tests: further test setup
1c7fed3
@russellwheatley
fix: back button email link
ca787a7
@russellwheatley
test: MFA resolution
69dfd19
@russellwheatley
chore: clean up logs/code comments
da1a999
@russellwheatley
fix: catch MFA error
a6b8a49
@russellwheatley
chore: clean up
3c78329
@russellwheatley
test: comment out test assertion that fails on emulator
f4e6384
@russellwheatley
feat: one tap copy of TOTP secret
abce28c
@russellwheatley
fix: only show keyboard once text field has been tapped
4763afd
@russellwheatley
fix: textfield comes into View when tapped
0c88e41
@russellwheatley
chore: previews for enrolment
ce8a513
@russellwheatley
fix: ensure barcode is visible and inputs come into view when tapped
c74865c
@russellwheatley
feat: allow opening app for creating TOTP auth
ee930ed
@russellwheatley
chore: display name is not optional
571f479
@russellwheatley russellwheatley changed the base branch from refactor-api to development October 7, 2025 12:52
@russellwheatley russellwheatley mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@russellwheatley